Revert "Issue #3463440 by mstrelan, smustgrave: Fix param docs identified by phpstan"

This reverts commit e07e27a6705b2da29c4c9b44dc000e09019586d5.

Author: nod_

lib/Drupal/Component/DependencyInjection/Dumper/OptimizedPhpArrayDumper.php

@@ -353,7 +353,7 @@ protected function dumpCallable($callable) {
   /**
    * Gets a private service definition in a suitable format.
    *
-   * @param string|null $id
+   * @param string $id
    *   The ID of the service to get a private definition for.
    * @param \Symfony\Component\DependencyInjection\Definition $definition
    *   The definition to process.

lib/Drupal/Component/Gettext/PoHeader.php

@@ -39,7 +39,7 @@ class PoHeader {
   /**
    * Author(s) of the file.
    *
-   * @var string[]
+   * @var string
    */
   protected $authors;
 

lib/Drupal/Component/Gettext/PoItem.php

@@ -105,8 +105,7 @@ public function setContext($context) {
   /**
    * Gets the source string(s) if the translation has plurals.
    *
-   * @return string|array
-   *   The source string or array of strings if it has plurals.
+   * @return string or array $translation
    */
   public function getSource() {
     return $this->source;
@@ -125,8 +124,7 @@ public function setSource($source) {
   /**
    * Gets the translation string(s) if the translation has plurals.
    *
-   * @return string|array
-   *   The translation string or array of strings if it has plurals.
+   * @return string or array $translation
    */
   public function getTranslation() {
     return $this->translation;

lib/Drupal/Core/Ajax/InsertCommand.php

@@ -24,7 +24,7 @@ class InsertCommand implements CommandInterface, CommandWithAttachedAssetsInterf
    * If the command is a response to a request from an #ajax form element then
    * this value can be NULL.
    *
-   * @var string|null
+   * @var string
    */
   protected $selector;
 
@@ -47,7 +47,7 @@ class InsertCommand implements CommandInterface, CommandWithAttachedAssetsInterf
   /**
    * Constructs an InsertCommand object.
    *
-   * @param string|null $selector
+   * @param string $selector
    *   A CSS selector.
    * @param string|array $content
    *   The content that will be inserted in the matched element(s), either a

lib/Drupal/Core/Block/Attribute/Block.php

@@ -25,8 +25,8 @@ class Block extends Plugin {
    *   the plugin. The array is keyed by context names.
    * @param class-string|null $deriver
    *   (optional) The deriver class.
-   * @param array<string, string|false> $forms
-   *   (optional) An array of form class names or FALSE, keyed by a string.
+   * @param string[] $forms
+   *   (optional) An array of form class names keyed by a string.
    */
   public function __construct(
     public readonly string $id,

lib/Drupal/Core/Config/ConfigInstallerInterface.php

@@ -40,7 +40,7 @@ public function installDefaultConfig($type, $name);
    * - it's a configuration entity.
    * - its dependencies can be met.
    *
-   * @param \Drupal\Core\Config\StorageInterface|null $storage
+   * @param \Drupal\Core\Config\StorageInterface $storage
    *   (optional) The configuration storage to search for optional
    *   configuration. If not provided, all enabled extension's optional
    *   configuration directories including the install profile's will be

lib/Drupal/Core/Extension/ModuleInstaller.php

@@ -616,7 +616,7 @@ function ($definition) {
   /**
    * Updates the kernel module list.
    *
-   * @param \Drupal\Core\Extension\Extension[] $module_filenames
+   * @param string[] $module_filenames
    *   The list of installed modules.
    */
   protected function updateKernel($module_filenames) {

lib/Drupal/Core/Test/FunctionalTestSetupTrait.php

@@ -198,7 +198,7 @@ protected function writeSettings(array $settings) {
    *
    * @param string $name
    *   The name of the parameter.
-   * @param string|array|bool $value
+   * @param string $value
    *   The value of the parameter.
    */
   protected function setContainerParameter($name, $value) {

modules/rest/tests/src/Functional/ResourceTestBase.php

@@ -434,7 +434,7 @@ protected function assertResourceResponse($expected_status_code, $expected_body,
    *
    * @param int $expected_status_code
    *   The expected response status.
-   * @param string|false $expected_message
+   * @param string $expected_message
    *   The expected error message.
    * @param \Psr\Http\Message\ResponseInterface $response
    *   The error response to assert.

tests/Drupal/Tests/Core/Utility/UnroutedUrlAssemblerTest.php

@@ -197,8 +197,8 @@ public function testAssembleWithStartingSlashEnabledProcessing(): void {
   /**
    * Setups the request stack for a given subdir.
    *
-   * @param bool $subdir
-   *   TRUE to use a subdir.
+   * @param string $subdir
+   *   The wanted subdir.
    */
   protected function setupRequestStack($subdir) {
     $server = [];