Skip to content

Commit b3de883

Browse files
committed
Issue #3250582 by huzooka, Matroskeen, danflanagan8, ravi.shankar, quietone, erik.erskine: ResponsiveImageStyles source plugin must extend DrupalSqlBase
1 parent da79b4f commit b3de883

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

modules/responsive_image/src/Plugin/migrate/source/d7/ResponsiveImageStyles.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
namespace Drupal\responsive_image\Plugin\migrate\source\d7;
44

5-
use Drupal\migrate\Plugin\migrate\source\SqlBase;
65
use Drupal\migrate\Row;
6+
use Drupal\migrate_drupal\Plugin\migrate\source\DrupalSqlBase;
77

88
/**
99
* Gets Drupal responsive image styles source from database.
@@ -20,7 +20,7 @@
2020
* source_module = "picture"
2121
* )
2222
*/
23-
class ResponsiveImageStyles extends SqlBase {
23+
class ResponsiveImageStyles extends DrupalSqlBase {
2424

2525
/**
2626
* {@inheritdoc}

modules/responsive_image/tests/src/Kernel/Migrate/d7/MigrateResponsiveImageStylesTest.php

+5
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ class MigrateResponsiveImageStylesTest extends MigrateDrupal7TestBase {
2222
*/
2323
protected function setUp(): void {
2424
parent::setUp();
25+
// Ensure the 'picture' module is enabled in the source.
26+
$this->sourceDatabase->update('system')
27+
->condition('name', 'picture')
28+
->fields(['status' => 1])
29+
->execute();
2530
$this->executeMigrations(['d7_image_styles', 'd7_responsive_image_styles']);
2631
}
2732

modules/responsive_image/tests/src/Kernel/Plugin/migrate/source/d7/ResponsiveImageStylesTest.php

+4-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,10 @@ class ResponsiveImageStylesTest extends MigrateSqlSourceTestBase {
1515
/**
1616
* {@inheritdoc}
1717
*/
18-
protected static $modules = ['responsive_image'];
18+
protected static $modules = [
19+
'migrate_drupal',
20+
'responsive_image',
21+
];
1922

2023
/**
2124
* {@inheritdoc}

0 commit comments

Comments
 (0)