Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The update:local_plugin script breaks when there is a space in the path #4

Open
dsebastien opened this issue May 14, 2024 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dsebastien
Copy link
Owner

When the $OBSIDIAN_VAULT_LOCATION variable contains a space (even escaped), the update:local_plugin script breaks. Although, the exact text of that script works fine when executed directly from the shell...

@dsebastien dsebastien added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels May 14, 2024
@mxthxngx
Copy link

hey could i try this?

@dsebastien
Copy link
Owner Author

dsebastien commented May 14, 2024 via email

@mxthxngx
Copy link

Could you tell me the doc where I can find steps to set this up locally? (Just getting started with Open source)

@dsebastien
Copy link
Owner Author

This is it: https://github.com/dsebastien/obsidian-plugin-template/blob/main/CONTRIBUTING.md

First, you need to install Node & npm.

Note that this is a meta-project, so there are various pitfalls to avoid, such as committing the package-lock.json, which doesn't make sense. The CI pipeline is also not functional because of that for instance. But I don't mind because it works with an actual project using this template

@dsebastien
Copy link
Owner Author

What I'd recommend for working on this issue, is to use a plugin that is based on this template, such as this one: https://github.com/dsebastien/obsidian-typefully, and fiddling with that one until you know what needs to be fixed in this repo. Then, you can follow the contributing guide to create a PR with the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants