Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wait for target" uses the selector, not the target #97

Open
lawik opened this issue Jun 28, 2021 · 1 comment
Open

"wait for target" uses the selector, not the target #97

lawik opened this issue Jun 28, 2021 · 1 comment

Comments

@lawik
Copy link
Contributor

lawik commented Jun 28, 2021

This means that it also skips any parent targets defined for that target.

This increases the risk of false positives a fair bit. For us it lead to a very ugly bug for us where a specific xpath target would do the expected thing but a CSS target would hit widely on the page by ignoring its parent and pass when it shouldn't.

@lawik
Copy link
Contributor Author

lawik commented Jun 28, 2021

Found the NOTE in the description while digging around the implementation. Realized that it is noted in the UI too. Not particularly clear for this use-case though and makes using chained targets/parents pretty much a footgun.

NOTE: This method is ignored by chained targets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant