Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check visibility attributes #90

Closed
fpoli opened this issue Jun 8, 2023 · 1 comment
Closed

Check visibility attributes #90

fpoli opened this issue Jun 8, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@fpoli
Copy link
Contributor

fpoli commented Jun 8, 2023 •
edited
Loading

Duchess currently doesn't check the visibility of the classes, methods and fields declared in a java_package!{ .. } macro. That is, a user might declare something as public while the item is actually private. A good place to implement these checks is at https://github.com/duchess-rs/duchess/blob/main/macro/src/check.rs.

This issue might be seen as part of #86, but I think it's possible to work on the two idependently.

To see an example of how to test the error messages, refer to the PR #81.
@fpoli fpoli added the good first issue Good for newcomers label Jun 8, 2023
@fpoli
Copy link
Contributor Author

fpoli commented Jun 26, 2023

Fixed by #93

@fpoli fpoli closed this as completed Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fpoli