+ merged changes from AuthorizeNet#31

dustinleeee · Nov 19, 2015 · 8eb6b39 · 8eb6b39
1 parent 7ff8ac5
commit 8eb6b39
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 5 deletions.
diff --git a/lib/authorize_net/xml_transaction.rb b/lib/authorize_net/xml_transaction.rb
@@ -76,13 +76,14 @@ def initialize(api_login_id, api_transaction_key, options = {})
       options = @@option_defaults.merge(options)
       @verify_ssl = options[:verify_ssl]
       @reference_id = options[:reference_id]
-      case options[:gateway]
-      when :sandbox, :test
-        @gateway = Gateway::TEST
-      when :production, :live
-        @gateway = Gateway::LIVE
+      @gateway = case options[:gateway].to_s
+      when 'sandbox', 'test'
+        Gateway::TEST
+      when 'production', 'live'
+        Gateway::LIVE
       else
         @gateway = options[:gateway]
+        options[:gateway]
       end
     end
 

diff --git a/spec/api_spec.rb b/spec/api_spec.rb
@@ -34,6 +34,15 @@
     expect(response.messages).not_to eq(nil) 
     expect(response.messages.resultCode).not_to eq(nil) 
     expect(response.messages.resultCode).to eq(MessageTypeEnum::Ok)
+
+    transaction = Transaction.new(@api_login, @api_key, :gateway => 'sandbox')
+    response = transaction.authenticate_test_request(@testRequest)
+
+    expect(response).not_to eq(nil)
+    expect(response.messages).not_to eq(nil) 
+    expect(response.messages.resultCode).not_to eq(nil) 
+    expect(response.messages.resultCode).to eq(MessageTypeEnum::Ok)
+
   end
 
   it "should be able to run credit card transaction" do

diff --git a/spec/arb_spec.rb b/spec/arb_spec.rb
@@ -51,8 +51,12 @@
   it "should know if its running against the sandbox or not" do
     transaction = AuthorizeNet::ARB::Transaction.new(@api_login, @api_key, :gateway => :sandbox)
     transaction.test?.should be_truthy
+    transaction = AuthorizeNet::ARB::Transaction.new(@api_login, @api_key, :gateway => 'sandbox')
+    transaction.test?.should be_truthy
     transaction = AuthorizeNet::ARB::Transaction.new(@api_login, @api_key, :gateway => :live)
     transaction.test?.should be_falsey
+    transaction = AuthorizeNet::ARB::Transaction.new(@api_login, @api_key, :gateway => 'live')
+    transaction.test?.should be_falsey
     transaction = AuthorizeNet::ARB::Transaction.new(@api_login, @api_key, :gateway => 'moose')
     transaction.test?.should be_truthy
   end

diff --git a/spec/cim_spec.rb b/spec/cim_spec.rb
@@ -45,8 +45,12 @@ def delete_profile(profile)
   it "should know if its running against the sandbox or not" do
     transaction = AuthorizeNet::CIM::Transaction.new(api_login, api_key, :gateway => :sandbox)
     expect(transaction.test?).to eq true
+    transaction = AuthorizeNet::CIM::Transaction.new(api_login, api_key, :gateway => 'sandbox')
+    expect(transaction.test?).to eq true
     transaction = AuthorizeNet::CIM::Transaction.new(api_login, api_key, :gateway => :live)
     expect(transaction.test?).to eq false
+    transaction = AuthorizeNet::CIM::Transaction.new(api_login, api_key, :gateway => 'live')
+    expect(transaction.test?).to eq false
     transaction = AuthorizeNet::CIM::Transaction.new(api_login, api_key, :gateway => 'moose')
     expect(transaction.test?).to eq true
   end