Chore: Respect Logging Pref of Parent/Supervisor App #42
Labels
chore
a tedious but necessary task often paying technical debt
discuss
Share your constructive thoughts on how to make progress with this issue
priority-2
Second highest priority, should be worked on as soon as the Priority-1 issues are finished
T1h
Time Estimate 1 Hour
As noted by @vans163 in #36 (comment) our current approach to logging
is a little crude and could result in a lot of noise and potentially even perf issues on a high traffic app. 💭
As highlighted in https://github.com/dwyl/envar/pull/36/files#diff-c24eb47ea99dc64a5109913f247d10fd83fa57e93cd9b4609cb703552215c901 there are 4 instances of
Logger
calls:envar/lib/envar.ex
Lines 31 to 33 in 03b035d
envar/lib/envar.ex
Lines 55 to 58 in 03b035d
envar/lib/envar.ex
Lines 165 to 170 in 03b035d
envar/lib/envar.ex
Lines 199 to 202 in 03b035d
Most of these are conditional, i.e. they won't log if the variable is set or file exists.
But this last one ... I have to agree with @vans163 is sloppy. 🤦♂️
Todo
Logs
into the project but they should:OFF
bydefault
i.e. not noisy! [they can be enabled on:dev
or:test
]Phoenix
) App.Side Quest:
The text was updated successfully, but these errors were encountered: