Update Gitea.clone to return tuple {:ok, path} or {:error, reason}

[SimonLab]

At the moment the clone function returns a string representing the path when the repository is cloned to.
However there isn't a way to know when the clone function has failed:

gitea/lib/gitea.ex

Lines 149 to 164 in 0c2bb0e

	def clone(git_repo_url) do
	org_name = get_org_name_from_url(git_repo_url)
	repo_name = get_repo_name_from_url(git_repo_url)
	local_path = local_repo_path(org_name, repo_name)
	Logger.info("git clone #{git_repo_url} #{local_path}")
	case inject_git().clone([git_repo_url, local_path]) do
	{:ok, %Git.Repository{path: path}} ->
	# Logger.info("Cloned repo: #{git_repo_url} to: #{path}")
	path
	{:error, git_err} ->
	Logger.error("Gitea.clone/1 tried to clone #{git_repo_url}, got: #{git_err.message}")
	local_path
	end
	end

We could update it to:

  def clone(git_repo_url) do
    org_name = get_org_name_from_url(git_repo_url)
    repo_name = get_repo_name_from_url(git_repo_url)
    local_path = local_repo_path(org_name, repo_name)
    Logger.info("git clone #{git_repo_url} #{local_path}")

    case inject_git().clone([git_repo_url, local_path]) do
      {:ok, %Git.Repository{path: path}} ->
        # Logger.info("Cloned repo: #{git_repo_url} to: #{path}")
        {:ok, path}

      {:error, git_err} ->
        Logger.error("Gitea.clone/1 tried to clone #{git_repo_url}, got: #{git_err.message}")
        {:error, git_err} # I would returns the git_err exception  and the client can either `raise git_err` or execute something else basd on the :error atom
    end
  end

[nelsonic]

@SimonLab do we need this today? 💭

[SimonLab]

I think it can wait, I'll create an issue on the application client to update the code once we have updated Gitea with this type of tuple response