Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk add previews that completely fail to fetch any videos can get their response cached #1289

Open
2 of 3 tasks
dyc3 opened this issue Feb 1, 2024 · 0 comments · May be fixed by #1787
Open
2 of 3 tasks

Bulk add previews that completely fail to fetch any videos can get their response cached #1289

dyc3 opened this issue Feb 1, 2024 · 0 comments · May be fixed by #1787
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dyc3
Copy link
Owner

dyc3 commented Feb 1, 2024

Current Behavior

It's possible for a bulk add preview, one with multiple links separated by newlines, to fail to get all of the videos requested. In this case, the add preview will still succeed, and the result will get cached. This will cause the user to be unable to get a fresh add preview

Expected Behavior

If grabbing all the videos fails, the add preview should fail with a non-200 status code, and exclude any caching headers.

Steps To Reproduce

Recommended: use miniserve to serve files over http

  1. In the add preview box, paste 2 links to non existent videos
  2. Wait for add preview to complete
  3. Bring up a webserver to serve videos to make the links in the add preview valid
  4. Refresh the add preview
  5. See the previous result remain

Environment

  • This happens on the official site, opentogethertube.com
  • This happens using a self-hosted version.
  • I'm using the docker image.

Anything else?

No response

@dyc3 dyc3 added the bug Something isn't working label Feb 1, 2024
@dyc3 dyc3 added the good first issue Good for newcomers label Feb 22, 2024
@IchanP IchanP linked a pull request Aug 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant