Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles are empty and shown in menu, and Title not reflecting the current page #314

Open
Fcmam5 opened this issue Jun 17, 2021 · 2 comments · Fixed by #321
Open

Articles are empty and shown in menu, and Title not reflecting the current page #314

Fcmam5 opened this issue Jun 17, 2021 · 2 comments · Fixed by #321
Labels
bug Something isn't working

Comments

@Fcmam5
Copy link

Fcmam5 commented Jun 17, 2021

As a random user (for real) I wanted to click on random articles, and un-luckily I landed on empty ones before I find the ones with actual content.

It might be that they were eyecatching (longer/more interesting titles or they were ranked before).

image

I think that it's better to have a small menu than to have a long one with empty content.


Also, another small bug: Page title doesn't change after leaving the page, so if I land on: https://www.dzcode.io/Learn/Git_Basics/What_The_Fork

My tab title will be "What the Fork!" everywhere.

Aaaand last: I suggest keeping the site name as a part of the tab title, so we should set:

<title>Article title | dzCode i/o</title>

@Fcmam5 Fcmam5 added the bug Something isn't working label Jun 19, 2021
@ZibanPirate
Copy link
Member

for the title issue, https://github.com/nfl/react-helmet should solve it

@ZibanPirate ZibanPirate changed the title Hide empty articles from menu, Articles are empty and shown in menu, and Title not reflecting the current page Jul 3, 2021
@ZibanPirate
Copy link
Member

reopening for the "Title" part of this issue

@ZibanPirate ZibanPirate reopened this Jul 3, 2021
@ZibanPirate ZibanPirate moved this to Backlog in DzCode i/o Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants