MM JOSE Review - ASF GDAL VRT Approach

[mikemorris12]

• The “High level science goals” are not really science goals, they are better classified as “Techniques”.
• I suggest using os.path.join instead of string addition when constructing file paths.
• Under “Create VRT Objects”, when opening the .txt and .vrt files, I suggest defining the directory path as a variable instead of repeating it in each file path string.
• A bit more guidance on how users should structure their own file paths would be useful. Using pre-defined variables would make it easier for users to define their own file paths and directories.
• The function “extract_metadata_attrs” is inflexible, it only works if your data directory path has the same number of characters as the author’s. Instead of defining vv_fb = inputfname[108:], the function should use os.path.basename to isolate the file name from the directory path.
• The order of the granule_id and product_id values in my version of vrt_full does not match the order of the values I can see on the webpage notebook. I’m not sure why, but this causes further issues down the line.
• I suggest you debug this issue using a version of the data freshly downloaded from Zenodo, since it might have to do with how the files are sorted in the zip archive.