-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request]: Add information about existing language repo #5259
Comments
Furthermore, the languages in instaled plugins are not also cosidered, so no one ever knows if it exists or not a translation for a specific plugin.... |
Please submit this as separate feature request |
my 2 cents : after examining 2 installs 1=2.3.3 and 1 = 2.4.x git so to get the onlinelang packs (those which available at a certain version!!!!! ) the system checks which version is installed and thus creates the call for the lang packs of that same version. I double checked the method by adjusting the corresponding file (;-)) running for test at 2.3.0 ( which basically IS a git 2.4.x version, but changed number) ehh voila all's there (see image) so a alternate version check (fixed one for onlinelangpacks call could be a solution).. on that icludes preset + 1 or 2 earlier. |
@tgtje We could add that. The remaining issue is that if someone installs an old pack and a constant "LAN" is missing. It could break their entire site (particularly if using PHP8), possibly preventing access to the admin area as well. |
I fully agree ( i just edited). (edit : idea behind : those will normally be added AFTER an install) |
This is a bit of a topsy-turvy world, it should just be that no errors in the code can bring down the entire website, certainly not the language files, if that can be caught, then it doesn't matter and you would just get a warning... that's my 2 cents... |
Because this is my FR, maybe solution:? :
|
Yeah I think your first suggestion would be best. With a message explaining why it's disabled. Optionally we could also implement the second option for developers to to still install language packs, but not sure. For developers it may be easier just to clone the appropriate GitHub repository. The issue is the way we use LANs, as constants, and the change in PHP8 to throw fatal errors. We'd need to catch those and ideally provide a fallback (English). This option may be best longer term but is far more complex to develop. For now I think we should stick to displaying the outdated version but not allowing it to download. |
Please, just use the class "disabled" in the install button. If you are a developer, you know how to install something that is disabled :)
Agree. The goal was to know about those packs. Link to repo could be useful too.
This is already solved for templates with {LAN}. There is a preference for loading English files if the native file is missing. I think that this is the wrong approach with PHP 8 around. |
The problem is that you still have both ways to display a LAN, and can't control how it's called, so if you keep calling LAN's via the constant and not using the shortcode.... |
Motivation
When this happens:
Add at least link to github repo and you can find older translations there. For new one it looks like e107 doesn't have any translation
Proposed Solution
Remove limitation for translation version
If it is not possible, add information for new users about language repo and existing translations.
Alternatives
you need to know - most people don't know
Additional Context
No response
The text was updated successfully, but these errors were encountered: