Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add low level functions for clouds via pybind #53

Open
tcmetzger opened this issue Oct 11, 2024 · 5 comments · May be fixed by #75
Open

Add low level functions for clouds via pybind #53

tcmetzger opened this issue Oct 11, 2024 · 5 comments · May be fixed by #75
Assignees
Milestone

Comments

@tcmetzger
Copy link
Collaborator

Additional low-level functions related to clouds and aerosols as defined in the C++ header files in the RTE+RRTMGP repository ( https://github.com/earth-system-radiation/rte-rrtmgp/blob/develop/rrtmgp-kernels/api/rrtmgp_kernels.h and https://github.com/earth-system-radiation/rte-rrtmgp/blob/develop/rte-kernels/api/rte_kernels.h) are available in Python, using pybind and the workflow established in Phase 1.

@tcmetzger tcmetzger added this to the Phase 2 milestone Oct 11, 2024
@tcmetzger tcmetzger changed the title Add low level functions for clouds and aerosols via pybid Add low level functions for clouds and aerosols via pybind Oct 11, 2024
@RobertPincus
Copy link
Member

@tcmetzger I made a start on this with earth-system-radiation/rte-rrtmgp#293 where I separated the cloud kernels. (The aerosol kernels being maybe too much of a mess.) When I made the change, though, one of my CI tests started to fail (GPUs using double precision, with the same code in single precision working fine.) I haven't resolved this but can come back to it.

@tcmetzger tcmetzger moved this to Backlog in pyRTE Phase 2 Oct 28, 2024
@tcmetzger
Copy link
Collaborator Author

In this phase, we won't do aerosols or only as a s stretch goal, if at all!

@RobertPincus RobertPincus changed the title Add low level functions for clouds and aerosols via pybind Add low level functions for clouds via pybind Nov 7, 2024
@RobertPincus
Copy link
Member

@tcmetzger @makepath-alex @sehnem C++ header files for cloud optics kernels are available on develop as of 06ea828
.

@makepath-alex
Copy link
Collaborator

Hi @RobertPincus,
Do you have any tips or suggestions for tests with corresponding .nc input/output files for the new Pybind functions:

  • rrtmgp_compute_tau_rayleigh
  • rrtmgp_compute_cld_from_table
  • rrtmgp_compute_cld_from_pade

@RobertPincus
Copy link
Member

Hi @RobertPincus, Do you have any tips or suggestions for tests with corresponding .nc input/output files for the new Pybind functions:

  • rrtmgp_compute_tau_rayleigh
  • rrtmgp_compute_cld_from_table
  • rrtmgp_compute_cld_from_pade

There are no existing stand-alone tests but these are all used in the all-sky example.

@makepath-alex makepath-alex linked a pull request Dec 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants