Skip to content

Commit

Permalink
seperate potential VERSION 0.8 features (#3554)
Browse files Browse the repository at this point in the history
Move the `no-use-registry-for-with-docker` and `earthly-ci-runner-arg`
features to a seperate section for features that will never be enabled
by default; where as the other unreleased features are likely to be
promoted to enabled for `VERSION 0.8`.

Signed-off-by: Alex Couture-Beil <[email protected]>
  • Loading branch information
alexcb authored Nov 30, 2023
1 parent bdb6381 commit 1b5ec23
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions features/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ import (
// Features is used to denote which features to flip on or off; this is for use in maintaining
// backwards compatibility
type Features struct {

// Never enabled by default
NoUseRegistryForWithDocker bool `long:"no-use-registry-for-with-docker" description:"disable use-registry-for-with-docker"` // escape hatch for disabling WITH DOCKER registry, e.g. used by eine-based tests
EarthlyCIRunnerArg bool `long:"earthly-ci-runner-arg" description:"includes EARTHLY_CI_RUNNER ARG"` // earthly CI was discontinued, no reason to enable this by default

// VERSION 0.5
ExecAfterParallel bool `long:"exec-after-parallel" description:"force execution after parallel conversion"`
ParallelLoad bool `long:"parallel-load" description:"perform parallel loading of images into WITH DOCKER"`
Expand Down Expand Up @@ -53,11 +58,9 @@ type Features struct {
WaitBlock bool `long:"wait-block" description:"enable WITH/END feature, also allows RUN --push mixed with non-push commands"`

// unreleased
NoUseRegistryForWithDocker bool `long:"no-use-registry-for-with-docker" description:"disable use-registry-for-with-docker"`
TryFinally bool `long:"try" description:"allow the use of the TRY/FINALLY commands"`
NoNetwork bool `long:"no-network" description:"allow the use of RUN --network=none commands"`
ArgScopeSet bool `long:"arg-scope-and-set" description:"enable SET to reassign ARGs and prevent ARGs from being redeclared in the same scope"`
EarthlyCIRunnerArg bool `long:"earthly-ci-runner-arg" description:"includes EARTHLY_CI_RUNNER ARG"`
UseDockerIgnore bool `long:"use-docker-ignore" description:"fallback to .dockerignore incase .earthlyignore or .earthignore do not exist in a local \"FROM DOCKERFILE\" target"`
PassArgs bool `long:"pass-args" description:"Allow the use of the --pass-arg flag in FROM, BUILD, COPY, WITH DOCKER, and DO commands"`
GlobalCache bool `long:"global-cache" description:"enable global caches (shared across different Earthfiles), for cache mounts and CACHEs having an ID"`
Expand Down

0 comments on commit 1b5ec23

Please sign in to comment.