Skip to content

Commit

Permalink
fix: don't warn when -ticktock image is used (#4154)
Browse files Browse the repository at this point in the history
Silence invalid warnings related to the -ticktock image being used. e.g.

Warning: Buildkit version (v0.8.12-ticktock) is different from Earthly
version (v0.8.12)

will no longer appear.

Signed-off-by: Alex Couture-Beil <[email protected]>
  • Loading branch information
alexcb authored May 24, 2024
1 parent 107e351 commit 2f61ff7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildkitd/buildkitd.go
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ func printBuildkitInfo(bkCons conslogging.ConsoleLogger, info *client.Info, work
if info.BuildkitVersion.Package != "github.com/earthly/buildkit" {
bkCons.Warnf("Using a non-Earthly version of Buildkit. This is not supported.")
} else {
if info.BuildkitVersion.Version != earthlyVersion {
if strings.TrimSuffix(info.BuildkitVersion.Version, "-ticktock") != earthlyVersion {
if isLocal {
// For local buildkits we expect perfect version match.
bkCons.Warnf(
Expand Down

0 comments on commit 2f61ff7

Please sign in to comment.