Skip to content

Commit

Permalink
Update dind references to r7 (#3516)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikejholly authored Nov 21, 2023
1 parent efe4f8d commit ae42b03
Show file tree
Hide file tree
Showing 19 changed files with 31 additions and 31 deletions.
2 changes: 1 addition & 1 deletion Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ lint-scripts:
earthly-script-no-stdout:
# This validates the ./earthly script doesn't print anything to stdout (it should print to stderr)
# This is to ensure commands such as: MYSECRET="$(./earthly secrets get -n /user/my-secret)" work
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
RUN apk add --no-cache --update bash
COPY earthly .earthly_version_flag_overrides .

Expand Down
8 changes: 4 additions & 4 deletions ast/tests/with-docker.ast.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{
"command": {
"args": [
"earthly/dind:alpine-3.18-docker-23.0.6-r4"
"earthly/dind:alpine-3.18-docker-23.0.6-r7"
],
"name": "FROM"
}
Expand Down Expand Up @@ -805,7 +805,7 @@
{
"command": {
"args": [
"earthly/dind:alpine-3.18-docker-23.0.6-r4"
"earthly/dind:alpine-3.18-docker-23.0.6-r7"
],
"name": "FROM"
}
Expand Down Expand Up @@ -864,7 +864,7 @@
{
"command": {
"args": [
"earthly/dind:alpine-3.18-docker-23.0.6-r4"
"earthly/dind:alpine-3.18-docker-23.0.6-r7"
],
"name": "FROM"
}
Expand Down Expand Up @@ -922,7 +922,7 @@
"command": {
"args": [
"+cgroup-v2-test",
"--DIND_IMG=earthly/dind:alpine-3.18-docker-23.0.6-r4",
"--DIND_IMG=earthly/dind:alpine-3.18-docker-23.0.6-r7",
"--DIND_IMG=earthly/dind:ubuntu-23.04-docker-24.0.5-1"
],
"name": "BUILD"
Expand Down
6 changes: 3 additions & 3 deletions docs/docker-images/dind.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ See the ["use-earthly-dind" best-practice](https://docs.earthly.dev/best-practic

## Tags

* `alpine-3.18-docker-23.0.6-r4`
* `alpine-3.18-docker-23.0.6-r7`
* `ubuntu-20.04-docker-24.0.5-1`
* `ubuntu-23.04-docker-24.0.5-1`

Expand All @@ -27,8 +27,8 @@ dind:
ARG EARTHLY_VERSION
ARG SMALLEST_VERSION="$(echo -e "$EARTHLY_VERSION\nv0.7.14" | sort -V | head -n 1)"
IF [ "$SMALLEST_VERSION" = "v0.7.14" ]
# earthly is at v0.7.14 or newer, and must use the more recent dind:alpine-3.18-docker-23.0.6-r4 image
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
# earthly is at v0.7.14 or newer, and must use the more recent dind:alpine-3.18-docker-23.0.6-r7 image
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
END
test:
Expand Down
2 changes: 1 addition & 1 deletion earthfile2llb/with_docker_run_base.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const (
dockerdWrapperPath = "/var/earthly/dockerd-wrapper.sh"
dockerAutoInstallScriptPath = "/var/earthly/docker-auto-install.sh"
composeConfigFile = "compose-config.yml"
suggestedDINDImage = "earthly/dind:alpine-3.18-docker-23.0.6-r4"
suggestedDINDImage = "earthly/dind:alpine-3.18-docker-23.0.6-r7"
)

// DockerLoadOpt holds parameters for WITH DOCKER --load parameter.
Expand Down
6 changes: 3 additions & 3 deletions inputgraph/testdata/with-docker/Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,21 @@ load-target:
SAVE IMAGE saved:latest

with-docker-load:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER --load saved:latest=+load-target
RUN echo "loaded"
END

with-docker-load-no-alias:
BUILD +load-target
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER --load +load-target
RUN echo "loaded"
END

with-docker-load-args:
BUILD +load-target
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER --load foo=(+load-target --foo=2)
RUN echo "loaded"
END
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

fail-with-docker-compose:
WORKDIR /test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

push:
ARG ACCT_ID
Expand Down
2 changes: 1 addition & 1 deletion tests/cloud-push-pull/azure-container-registry.earth
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

push:
RUN date | md5sum | head -c 32 > motd
Expand Down
2 changes: 1 addition & 1 deletion tests/cloud-push-pull/google-artifact-repository.earth
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

push:
RUN date | md5sum | head -c 32 > motd
Expand Down
2 changes: 1 addition & 1 deletion tests/cloud-push-pull/google-container-registry.earth
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

push:
RUN date | md5sum | head -c 32 > motd
Expand Down
2 changes: 1 addition & 1 deletion tests/ssh.earth
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ test:
RUN --ssh test -n "$SSH_AUTH_SOCK" && ssh-add -l | grep 'rsa-key-from-earthly-tests'

test-with-docker:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
RUN apk --update add openssh-client
WITH DOCKER
RUN --ssh test -n "$SSH_AUTH_SOCK" && ssh-add -l | grep 'rsa-key-from-earthly-tests'
Expand Down
2 changes: 1 addition & 1 deletion tests/visited-upfront-hash-collection.earth
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
VERSION --use-visited-upfront-hash-collection 0.7

FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

parallel:
BUILD +test-executor --INDEX=1
Expand Down
4 changes: 2 additions & 2 deletions tests/wait-block/save-image/Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ check-tag-exists-locally:
RUN docker images "$REGISTRY/myuser/myimg:$tag" | grep "$tag"

check-with-docker-pull-works:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
ARG --required REGISTRY
ARG --required tag
WITH DOCKER --pull $REGISTRY/myuser/myimg:$tag
RUN docker images "$REGISTRY/myuser/myimg:$tag" | grep "$tag"
END

check-with-docker-load-works:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER --load mytestimg=+myimg
RUN docker run mytestimg /bin/sh -c 'cat /special-data' | grep NWMyMTQ2Y
END
Expand Down
2 changes: 1 addition & 1 deletion tests/wait-block/with-docker-run-load/Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ a-test-image:
SAVE IMAGE $REGISTRY/myuser/myimg:$tag

test:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
ARG --required REGISTRY
ARG --required tag
WAIT
Expand Down
2 changes: 1 addition & 1 deletion tests/with-docker-expose/Earthfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

all:
BUILD +test-single
Expand Down
4 changes: 2 additions & 2 deletions tests/with-docker-kind/Earthfile
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

all:
ARG KIND_VERSION=0.20.0
BUILD +alpine-kind --KIND_VERSION=$KIND_VERSION
BUILD +ubuntu-kind --KIND_VERSION=$KIND_VERSION

alpine-kind:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
RUN apk add curl
ARG --required KIND_VERSION
RUN curl -Lo ./kind https://kind.sigs.k8s.io/dl/v$KIND_VERSION/kind-linux-amd64 && chmod +x kind
Expand Down
2 changes: 1 addition & 1 deletion tests/with-docker-registry/Earthfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

all:
BUILD +empty-test
Expand Down
2 changes: 1 addition & 1 deletion tests/with-docker-via-command/Earthfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ MY_COMMAND_WITH_DOCKER:
END

test:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
DO +MY_COMMAND_WITH_DOCKER --MY_ARG="myvalue"
DO +MY_COMMAND_WITH_DOCKER
8 changes: 4 additions & 4 deletions tests/with-docker/Earthfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
VERSION 0.7
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7

all:
BUILD +empty-test
Expand Down Expand Up @@ -136,7 +136,7 @@ multi-from-two:
FROM alpine:latest

one-target-many-names:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER \
--load a:latest=+multi-from-one \ # Test that there can be multiple names assigned to an image from a single target
--load b:latest=+multi-from-one \
Expand All @@ -150,7 +150,7 @@ one-target-many-names:
END

if-after:
FROM earthly/dind:alpine-3.18-docker-23.0.6-r4
FROM earthly/dind:alpine-3.18-docker-23.0.6-r7
WITH DOCKER --load a:latest=+multi-from-one
RUN docker run a:latest
END
Expand All @@ -161,7 +161,7 @@ if-after:

cgroup-v2-test-all:
BUILD +cgroup-v2-test \
--DIND_IMG=earthly/dind:alpine-3.18-docker-23.0.6-r4 \
--DIND_IMG=earthly/dind:alpine-3.18-docker-23.0.6-r7 \
--DIND_IMG=earthly/dind:ubuntu-23.04-docker-24.0.5-1

cgroup-v2-test:
Expand Down

0 comments on commit ae42b03

Please sign in to comment.