New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vector copy implied in parseCartesianPosition and parseSphericalPosition #188

Open

tomjnixon opened this issue Jan 11, 2024 · 0 comments

Member

tomjnixon commented Jan 11, 2024

This accepts a vector of nodes:

libadm/src/private/xml_parser.cpp

Line 768 in 3f94a9b

CartesianPosition parseCartesianPosition(std::vector<NodePtr> nodes) {

and it's not moved in here:

libadm/include/adm/private/xml_parser_helper.hpp

Line 254 in 3f94a9b

value = NT(parser(elements));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment