Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOM] NaiveASTFlattener should be sync with ASTFlattener of the JDT.UI #3261

Open
subyssurendran666 opened this issue Nov 6, 2024 · 5 comments · May be fixed by #3268
Open

[DOM] NaiveASTFlattener should be sync with ASTFlattener of the JDT.UI #3261

subyssurendran666 opened this issue Nov 6, 2024 · 5 comments · May be fixed by #3268
Assignees
@subyssurendran666

Comments

@subyssurendran666
Copy link
Contributor

subyssurendran666 commented Nov 6, 2024 •
edited
Loading

The unnamed variables and pattern's DOM and ASTRewrite implemented through #2623. Following items should be added along with that.

  • The Javadoc of both APIs i.e. TypePattern.getPatternVariable() and TypePattern.getPatternVariable2() is same and not clear regarding the difference.
  • The methods in JDT UI's ASTFlattener are kept in sync with NaiveASTFlattener(TypePattern). Hence, the change should be done in NaiveASTFlattener as well and then synced to ASTFlattener.

The Problem has reported here: eclipse-jdt/eclipse.jdt.ui#1764 (comment)
@subyssurendran666
Copy link
Contributor Author

@mpalat could you please assign this ticket to me ?

@carstenartur
Copy link
Contributor

Maybe you can fix the indenting issue while at it? A fix is available here:

https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/181069

@jarthana
Copy link
Member

jarthana commented Nov 7, 2024

Maybe you can fix the indenting issue while at it? A fix is available here:

https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/181069

Carsten, that looks like quite a big patch! Would you mind putting that in a PR in your name here? TIA!

@subyssurendran666 subyssurendran666 linked a pull request Nov 8, 2024 that will close this issue
Open
3 tasks
@carstenartur
Copy link
Contributor

Maybe you can fix the indenting issue while at it? A fix is available here:

https://git.eclipse.org/r/c/jdt/eclipse.jdt.core/+/181069

Carsten, that looks like quite a big patch! Would you mind putting that in a PR in your name here? TIA!

Hi @jarthana, imho it has a really low priority. I found it in a debug session where the strange formatting appears using inspect on some objects. You can see in the gerrit that only a few tests are affected. I'm not sure if there is a "real world" impact somewhere. So I hesitate wasting time on it again. I thought it is a different thing when you have to touch the code anyway.

@jarthana
Copy link
Member

Hi @jarthana, imho it has a really low priority. I found it in a debug session where the strange formatting appears using inspect on some objects. You can see in the gerrit that only a few tests are affected. I'm not sure if there is a "real world" impact somewhere. So I hesitate wasting time on it again. I thought it is a different thing when you have to touch the code anyway.

OK, then let's not worry about it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subyssurendran666 subyssurendran666

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jarthana @carstenartur @subyssurendran666