[performance] BoundSet: move properTypesByInferenceVariable before loop #3597
Conversation
|
reduces reproducer #3594 (comment) from 17.7s to 5s after: |
|
I'll take a look, though not right now ... |
There was a problem hiding this comment.
The change is technically sound.
In addition to the cleanup request, I'd like to see one more measurement:
You reported that the extreme case from #3594 (comment) benefits from the change, good.
What about "normal" usage? The computation properTypesByInferenceVariable() will now be performed always, even if its result is never used. Does this method appear in any measurements of, e.g., GenericsRegressionTest_1_8?
org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/BoundSet.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/lookup/BoundSet.java
Outdated
Show resolved
Hide resolved
as it does not depend on the loop variables improves eclipse-jdt#3590 drastically
jukzi
force-pushed
the
properTypesByInferenceVariable
branch
from
e62b428 to
d73bf0a
Compare
I executed GenericsRegressionTest_1_8 with and without this PR and could not see a performance difference above the normal jitter. Both cases take ~ 1:22 +/-1sec to run. The method is used during that test for ~200ms. Its caller, BoundSet.incorporate(), is dominated by another method reduceOneConstraint(). |
There was a problem hiding this comment.
I executed GenericsRegressionTest_1_8 with and without this PR and could not see a performance difference above the normal jitter. Both cases take ~ 1:22 +/-1sec to run. The method is used during that test for ~200ms. Its caller, BoundSet.incorporate(), is dominated by another method reduceOneConstraint().
As far as i understand properTypesByInferenceVariable() is super fast on cases that would not require to compute it and would only take significant time if the result will be used.
Just from that one screenshot I couldn't 100% follow your reasoning, but I appreciate you had a look into it.
as it does not depend on the loop variables
improves #3590 drastically