Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The method public static KeySetView<K,java.lang.Boolean> newKeySet() is wrongly tagged as containing missing types #3726

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

stephan-herrmann
Copy link
Contributor

Avoid tagging the method, when the target type has a missing type

Tentatively turn the syserrs into assert false : "message"

Fixes #3501

@stephan-herrmann stephan-herrmann added this to the 4.35 M3 milestone Feb 11, 2025
wrongly tagged as containing missing types

Avoid tagging the method, when the target type has a missing type

Tentatively turn the syserrs into assert false : "message"

Fixes eclipse-jdt#3501
wrongly tagged as containing missing types

Do report when missing type was touched only during type inference
+ use that missing type with a new error message

Fixes eclipse-jdt#3501
@stephan-herrmann stephan-herrmann merged commit 5f438d7 into eclipse-jdt:master Feb 13, 2025
10 checks passed
@stephan-herrmann stephan-herrmann deleted the issue3501 branch February 13, 2025 11:40
@stephan-herrmann
Copy link
Contributor Author

stephan-herrmann commented Feb 13, 2025

For posterity one comment about intermediate failure in JavaSearchBugs16Tests.testAIOOBEForRecordClassGh790 :

That test uses compliance 16, but when run on JDK 23 search tries to resolve types from the JDK's source attachment! It so happens that those source cause tons of compile errors at compliance 16. Most notably I saw several occurrences of sealed causing a lot of havoc.

This is another indication that the --release option is not helpful in some IDE use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant