[24] Monitor failures in tests of Y-Builds

[stephan-herrmann]

Meanwhile we have meaningful test results in these builds

• https://ci.eclipse.org/releng/job/YPBuilds/job/ep434Y-unit-cen64-gtk3-java24
• https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/BETA_JAVA24

I suggest we monitor these builds to catch any problems early

[stephan-herrmann]

As of today I see these failures:

• Y-Build
  • org.eclipse.jdt.debug.tests.core 7 failures
  • org.eclipse.jdt.debug.tests.launching 2 failures
  • org.eclipse.jdt.debug.tests.variables 1 failure
• jdt.debug BETA_JAVA24
  • zero failures -- still running on Java 21

[stephan-herrmann]

Results in https://ci.eclipse.org/releng/job/YPBuilds/job/ep434Y-unit-cen64-gtk3-java24/10/testReport/ :

• org.eclipse.jdt.debug.tests.core: 6 failures (-1)
• org.eclipse.jdt.debug.tests.launching: 2 failures
• org.eclipse.jdt.debug.tests.variables: 0 failures (-1)
• org.eclipse.jdt.debug.tests.ui: 1 failure (+1)

New feailure is in VirtualThreadsDebugViewTests.testVirtualThreadDebugView:

expected no launches after test expected:<[]> but was:<[org.eclipse.debug.core.Launch@4e2cfa12]>

[stephan-herrmann]

Build failed: https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/BETA_JAVA24/3

Error is:

[2024-11-27T06:01:43.632Z] [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.10:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.jdt.debug.tests: Only qualifier changed for (org.eclipse.jdt.debug.tests/3.12.550.v20241127-0537). Expected to have bigger x.y.z than what is available in baseline (3.12.550.v20241114-1350) -> [Help 1]

[stephan-herrmann]

After temporary breakage of tests, we have fresh results again: no changes wrt. the Nov 7 results.

[stephan-herrmann]

Detailed test report for jdt.debug: https://download.eclipse.org/eclipse/downloads/drops4/Y20250106-1000/testresults/html/org.eclipse.jdt.debug.tests_ep435Y-unit-linux-x86_64-java24_linux.gtk.x86_64_24.html

Console log is here: https://download.eclipse.org/eclipse/downloads/drops4/Y20250106-1000/testresults/ep435Y-unit-linux-x86_64-java24_linux.gtk.x86_64_24/org.eclipse.jdt.debug.tests.AutomatedSuite.txt

Log file contains this:

JRE Eclipse Adoptium/24-beta is not supported, advanced source lookup disabled.
 Eclipse debugger will use less precise source lookup implementation for this debug session, but everything else will continue to work otherwise.
Upgrading Eclipse to the latest version will likely make this warning go away.one

Does anyone know, where this Java version needs to be made known?

[stephan-herrmann]

Detailed test report for jdt.debug: https://download.eclipse.org/eclipse/downloads/drops4/Y20250106-1000/testresults/html/org.eclipse.jdt.debug.tests_ep435Y-unit-linux-x86_64-java24_linux.gtk.x86_64_24.html

Console log is here: https://download.eclipse.org/eclipse/downloads/drops4/Y20250106-1000/testresults/ep435Y-unit-linux-x86_64-java24_linux.gtk.x86_64_24/org.eclipse.jdt.debug.tests.AutomatedSuite.txt

Log file contains this:

JRE Eclipse Adoptium/24-beta is not supported, advanced source lookup disabled.
 Eclipse debugger will use less precise source lookup implementation for this debug session, but everything else will continue to work otherwise.
Upgrading Eclipse to the latest version will likely make this warning go away.

Does anyone know, where this Java version needs to be made known?

This is not specific to Adoptium. After switch to openjdk we see

JRE Oracle Corporation/24-ea is not supported, advanced source lookup disabled.
 Eclipse debugger will use less precise source lookup implementation for this debug session, but everything else will continue to work otherwise.
Upgrading Eclipse to the latest version will likely make this warning go away.

Other than that no changes as of https://ci.eclipse.org/releng/job/YPBuilds/job/ep435Y-unit-linux-x86_64-java24/26/testReport/

[akurtakov]

This comes from

eclipse.jdt.debug/org.eclipse.jdt.launching.javaagent/src/main/java/org/eclipse/jdt/launching/internal/javaagent/Premain.java

Line 35 in 1639f4b

if (major < 0 || major > ClassfileTransformer.MAX_CLASS_MAJOR) {

which does check java.lang.instrument.ClassFileTransformer.MAX_CLASS_MAJOR but there is

eclipse.jdt.debug/org.eclipse.jdt.launching.javaagent/src/main/java/org/eclipse/jdt/launching/internal/weaving/ClassfileTransformer.java

Line 28 in 1639f4b

public static final int MAX_CLASS_MAJOR = Opcodes.V24;

which is at Java24 level (thanks to newer ASM than JVM).
@stephan-herrmann Do you think using the later one instead of the former will allow having support for Java 24 now?

[stephan-herrmann]

@stephan-herrmann Do you think using the later one instead of the former will allow having support for Java 24 now?

I'm not quite sure what exactly you are suggesting, as one constant is just an alias for the other.

It should accept Java24 since #542.

To check: was org.eclipse.jdt.launching/lib/javaagent-shaded.jar correctly re-built? I can see it checked in with #542 but haven't looked inside.

[stephan-herrmann]

After merge from master #594 the next BETA_JAVA24 build was green: https://ci.eclipse.org/jdt/job/eclipse.jdt.debug-github/job/BETA_JAVA24/4