Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdt.ui's main README #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Contributor

What it does

Update links, remove obsolete sections and use simpler markdown style, similar to jdt.core's README.

Author checklist


Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the announced deprecation of php-content on eclipse.dev websites I assume this link will not work well for a long time, but at the moment there is nothing better I know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should point to the php page. It is out of date and points to other out of date pages. I would suggest you either leave the link above (which is archived) or create a new .md file by stealing any relevant text from the php page you pointed to, replacing or simply removing any php links. This at least gives a base for building on.

CONTRIBUTING Show resolved Hide resolved
Update links, remove obsolete sections and use simpler markdown style.
@HannesWell
Copy link
Contributor Author

@jjohnstn can you please review this?

@jjohnstn
Copy link
Contributor

@HannesWell @jukzi I was on vacation. Will do.


Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should point to the php page. It is out of date and points to other out of date pages. I would suggest you either leave the link above (which is archived) or create a new .md file by stealing any relevant text from the php page you pointed to, replacing or simply removing any php links. This at least gives a base for building on.


Contributor License Agreement:
------------------------------
- https://eclipse.dev/jdt/ui/index.php#dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is still a link to the php page :-(

See https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need that file at all, when it contains a link only? better just delete it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants