Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to icu4j for html exports #1574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jan 18, 2025

The only reason for icu4j currently is to determine if a RTL language is used as the default locale on html exports.

This replaces the fat (12MB!) dependency by a simpler variant that seems suitable for the sake of generating html reports.

The list of codes is taken from https://raw.githubusercontent.com/shadiabuhilal/rtl-detect/2eed8a33276461a24e7033d1d3a115ee64aee3f5/lib/rtl-detect.js and adapted to java.

The only reason for icu4j currently is to determine if a RTL language is
used as the default locale on html exports.

This replaces the fat (12MB!) dependency by a simpler variant that seems
suitable for the sake of generating html reports.
@laeubi
Copy link
Contributor Author

laeubi commented Jan 18, 2025

@waynebeaton I'm not really sure about the "IP" here, is a list of strings already something we need a vetting from the IP team? The source where I found the list mentions New BSD License Theoretical I could extract the code into an on class and license it under that as well... I'm just not sure if this is a bit exaggerated here...

Copy link

Test Results

   285 files  +  6     285 suites  +6   49m 54s ⏱️ - 2m 32s
 3 586 tests ±  0   3 510 ✅ +  2   76 💤  -  1  0 ❌  - 1 
10 950 runs  +194  10 719 ✅ +167  231 💤 +28  0 ❌  - 1 

Results for commit 7bd363b. ± Comparison against base commit 48aa45c.

@laeubi
Copy link
Contributor Author

laeubi commented Jan 19, 2025

It would maybe better to move the code to https://github.com/eclipse-equinox/equinox/tree/master/bundles/org.eclipse.equinox.bidi so it can be reused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant