Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with index.d.ts #144

Open
maexrakete opened this issue May 17, 2020 · 2 comments
Open

Release with index.d.ts #144

maexrakete opened this issue May 17, 2020 · 2 comments

Comments

@maexrakete
Copy link

Hey there!

in #112 you merged the index.d.ts with the function signatures but you didn't trigger the release since then. This means the index.d.ts file is not available when installing the package.

(Also seems the latest version on npm is 4.1.0 while this repo is at 5)

Cheers!

@craigjmidwinter
Copy link

Sorry to bump an old thread, but it would be awesome to get the latest into a new release

@edwellbrook
Copy link
Owner

👋 Hey!

Would love to get this into a new release.

As you may have noticed, I'm not able to actively maintain this library. I would love some help getting everything rounded off for a 5.0.0 release.

I've taken a few minutes already today to do some quick maintenance:

  • closed a bunch of auto-generated PRs
  • updated the library to require node 14+
  • moved tests to run through GitHub actions

What's left:

  • Deciding how new versions of the tvdb API should be handled (we're pinning(?) to 'v2.1.1', should we raise this? How does this affect semver?)
  • Reviewing and merging Refresh JWT when required to stop it expiring #114
  • Updating index.d.ts to include any recent changes (presumably including the refreshToken function from above PR)
  • Re-generating docs
  • Publishing 5.0.0 to npm

Any help with moving forward on the points above would be extremely helpful. As I don't have the bandwidth to resolve all of this myself, I'd need interested parties to help organise.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants