Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to ban direct imports from 'effector/effector.umd', 'effector/effector.cjs', 'effector/effector.mjs' #148

Open
NazariiShvets opened this issue Oct 3, 2023 · 4 comments

Comments

@NazariiShvets
Copy link

Proposal

Add eslint rule to ban direct imports from 'effector/effector.umd', 'effector/effector.cjs', 'effector/effector.mjs' (with autofix)
so it would be possible to catch/fix such cases with linter

Use case

For now i need to do it in PR or manual cleaning once a couple weeks. It would be great to have that automated

@igorkamyshev
Copy link
Member

I'm sure why we have to do it 🤔 Can you elaborate a bit? It seems like a bug in JetBrains products, and as I understand, they accept it. I've found a couple of links there, you can subscribe 👇

@NazariiShvets
Copy link
Author

Sure, thanks for suggestion. I did ban it for my local environment, but:

  • I also use different IDE`s for specific usecases
  • Can't share .idea with my teammates via git because it would trash it with any personal stuff within IDE

I preffer automation over manual checks or dealing with config syncronization accross different IDEs, projects, etc

@igorkamyshev
Copy link
Member

Other IDE's do not have this bug, right? So, it is a problem of JetBrains, I sent some links, they confirmed it 😇

Why shall we introduce workarounds for JetBrains' bugs?

@zerobias
Copy link
Member

@igorkamyshev I encountered it in vs code more than once, JetBrains just seems to be more prone to this kind of bugs, so I suggest adding this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants