Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling kick-rewrites should be possible #969

Open
thommey opened this issue Apr 13, 2020 · 1 comment
Open

Disabling kick-rewrites should be possible #969

thommey opened this issue Apr 13, 2020 · 1 comment

Comments

@thommey
Copy link
Member

thommey commented Apr 13, 2020

Kick-rewrites intercept all messages in our msg queues, even when sent directly from Tcl, to rewrite kicks (for tracking nick-changes). Disabling it completely should make Eggdrop not rewrite the queues. It still does though, and removes kicks of people who are not on the channel. This conflicts scripts that try to send a kick (directly, via putserv). Example scenario is a script supporting +D (invisible users) on ircu.

Found by: Empus

@michaelortmann
Copy link
Member

Regarding #1307 purge_kicks() is only executed when optimize-kicks is set to 2:

if (optimize_kicks == 2) {
purge_kicks(h);

So, what should we do with this issue?

  1. Can the bot detect if the irc server it is on supports +D (invisible users) and should it warn if optimize-kicks is set to 2 in this case?

  2. Does the bot really optimize out kicks when optimize-kicks is set to 0? In this case we need to find out where this happens, for it does not happen via purge_kicks()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants