chore: combine primitives #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th7nder
previously approved these changes
Nov 28, 2024
There was a problem hiding this comment.
I don't have a strong opinion on primitives as not sure we splitted them in first place, I guess consolidation now makes sense. If we need to, we'll split it later. That's fine.
About getting rid of the cli directory, 100% on-board. I didn't make much sense to have it there.
cernicc
added
ready for review
cernicc
added
ready for review
th7nder
approved these changes
Nov 28, 2024
aidan46
approved these changes
Nov 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combine primitives to a single create. Move
storage-providerto the root of the project.