[Bug] Fix Slack notifications for releases

[Himangini]

Failed run for RC 😭

Related ticket: #4944
Seems like the notifications added as part of this ticket aren't working as expected and are failing with the error

Error: Error: An API error occurred: not_authed
Error: An API error occurred: not_authed

Edit: In addition, start publishing in aws-dev channel as well.

[aclevername]

I don't understand why 😢 the secret used is identical for the build-all-distros-nightly which worked.

https://github.com/weaveworks/eksctl/blob/166abfcd673126efe42f77db00971f8aafc9f548/.github/workflows/build-all-distros-nightly.yaml#L40

https://github.com/weaveworks/eksctl/blob/166abfcd673126efe42f77db00971f8aafc9f548/.github/workflows/publish-release-type.yaml#L62

[Himangini]

We also stopped publishing success release messages on aws-dev channel which was missed in the related ticket. As part of this one we should add it back

[aclevername]

yeah I just added it to #team-pitch-black instead of #aws-dev, mb!

[Skarlso]

The slack notification is working as it can be seen here:
https://github.com/weaveworks/eksctl/runs/5767330437?check_suite_focus=true

It might have been some kind of fluke. The error suggests that the token wasn't sent along.

I suggest closing this for now and then re-opening if it occurs again. I don't see any problems with the config or the setup. ¯\_(ツ)_/¯.

[Himangini]

@Skarlso we need to add the notifications to aws-dev channel too. These need to work for releases so we need to make sure slack notifications are sent for releases, not just test runs.

[Skarlso]

we need to add the notifications to aws-dev channel too.

This was an addition on the comments, not part of the original description. :) I missed it. :))

These need to work for releases so we need to make sure slack notifications are sent for releases, not just test runs.

It's practically irrelevant from where this has run because the configuration is the same. The point of the test was to see if the token is there or not and it's being used correctly which is what the test was for.

In any case, I guess this needs to be edited to include sending notification on an additional channel, and once we do a release we'll be able to test this. Until then, this cannot be best reproduced I guess 🤔. Maybe the release messes something up. We'll have to see when we get there. :)

Edit: Updated the description to include publishing to aws-dev channel.

[Skarlso]

Huh, the action doesn't allow for a list of channel names... What a bummer.

[Skarlso]

For what it's worth, I opened: actions-ecosystem/action-slack-notifier#334

And will be implementing it shortly. Let's hope it gets merged, otherwise, I will just duplicate the action for now ¯\_(ツ)_/¯

[Himangini]

Another run for Release 0.90 failed with the same error

Error: Error: An API error occurred: not_authed
Error: An API error occurred: not_authed

[Skarlso]

The channel update is not yet done.

[Skarlso]

I'm waiting one more day for the respective pr to be merged, if not, I'll duplicate the actions. ¯\_(ツ)_/¯