Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support instanceTypes override when using custom LaunchTemplate #8044

Open
youwalther65 opened this issue Nov 25, 2024 · 0 comments
Labels
kind/feature New feature or request

Comments

@youwalther65
Copy link

What feature/behavior/change do you want?

Currently trying to create a managed node group (MNG) with custom LaunchTemplate and instanceTypes like this

managedNodeGroups:
- name: mng-custom-AL2023
  minSize: 1
  maxSize: 2
  desiredCapacity: 2
  instanceTypes: [ "m6gd.large", "m7gd.large" ]
  launchTemplate:
    id: lt-089fa9a17a94857cd
    version: 5
  updateConfig:
    maxUnavailable: 1

leads to the following error

$ eksctl create nodegroup -f eksctl-NVME-AL2023.yaml
Error: couldn't create node group filter from command line options: loading config file "eksctl-NVME-AL2023.yaml": json: cannot unmarshal number into Go struct field LaunchTemplate.managedNodeGroups.launchTemplate.version of type string

Why do you want this feature?

A LaunchTemplate only supports just one InstanceType , therefore having it in the MNG as an instance override is the only way to have instance diversification which helps to avoid running into InsufficientInstanceCapacity errors.

@youwalther65 youwalther65 added the kind/feature New feature or request label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant