Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readme note for auto mode and hybrid nodes #8070

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

geoffcline
Copy link
Contributor

@geoffcline geoffcline commented Dec 2, 2024

add a note to the github readme that announces eks auto mode support, the required version, and links to the EKS docs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello geoffcline 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@a-hilaly a-hilaly enabled auto-merge December 2, 2024 19:16
a-hilaly
a-hilaly previously approved these changes Dec 2, 2024
@eqe-aws eqe-aws requested a review from a-hilaly December 2, 2024 19:19
TiberiuGC
TiberiuGC previously approved these changes Dec 2, 2024
@a-hilaly a-hilaly disabled auto-merge December 2, 2024 19:30
@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label Dec 2, 2024
@geoffcline geoffcline dismissed stale reviews from TiberiuGC and a-hilaly via 0d2681d December 2, 2024 19:40
@geoffcline geoffcline changed the title add readme note for auto mode add readme note for auto mode and hybrid nodes Dec 2, 2024
@geoffcline
Copy link
Contributor Author

added links to markdown files, and note for hybrid nodes also

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @geoffcline !

@a-hilaly a-hilaly enabled auto-merge December 2, 2024 19:44
@a-hilaly a-hilaly merged commit 6733c6d into eksctl-io:main Dec 2, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release-notes Causes PR not to show in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants