[feature request] battery full border color.

[ajoino]

Hi.

I like this repository a lot, and I am willing to help with this feature request.

I would like to add a color option for the border when the battery is full.
However, I am not sure how to test those changes in my live qtile session and thus I am not sure how to make sure the changes take effect.

If this idea sounds good, would you mind describing or linking to a description on how to change and test this lib?

[elParaguayo]

It's certainly possible to do.

You'd need to add some new parameters to defaults, one for the border colour and one to set the level for treating the battery as "full".

Then, you just need to add some logic to this section to check whether the battery is full:

qtile-extras/qtile_extras/widget/upower.py

Lines 300 to 304 in 159eb19

	# Choose border colour
	if (percentage <= self.percentage_critical) and not self.charging:
	border = self.border_critical_colour
	else:
	border = self.borders[self.charging]

[ajoino]

Glad to hear a positive response.

What are the best practices for developing and testing this module? Just run pip install . -e in the repo?

[elParaguayo]

Each to their own. I use a virtual environment linked to my development versions of qtile and qtile-extras and I run it in a separate tty.