Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inference search notebook error with model_id vs inference_id after 8.13 upgrade #220

Closed
miguelgrinberg opened this issue Apr 4, 2024 · 2 comments · Fixed by #221
Closed
Assignees

Comments

@miguelgrinberg
Copy link
Collaborator

Issue from @derickson

My environment

The Semantic search step uses the follwing as it's knn query

{
        "field": "plot_embedding",
        "query_vector_builder": {
            "text_embedding": {
                "inference_id": "my_openai_embedding_model",
                "model_text": "Fighting movie",
            }
        },
        "k": 10,
        "num_candidates": 100,
    }

which does not work in 8.13

changing to "model_id" instead of "inference_id" solves the issue. This notebook was written for 8.12

the note at the end is innacurate

"NOTE: If you use Elasticsearch 8.12, you must change inference_id in the snippet above to model_id."

@miguelgrinberg
Copy link
Collaborator Author

This relates to a recent change by @szabosteve. Assigning to him.

@szabosteve
Copy link
Contributor

@miguelgrinberg The issue is that the query_vector_builder does not accept inference_id only model_id yet. I opened a PR to fix the problem. Thank you for opening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants