From 578c13165446c45246ef428d8266274c759dd802 Mon Sep 17 00:00:00 2001 From: Brujo Benavides Date: Mon, 15 Sep 2014 18:06:37 -0300 Subject: [PATCH] [Fixes #8] REJECTED: LC instead of lists:map --- CONTRIBUTING.md | 2 +- REJECTED.md | 25 +++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 REJECTED.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 825fe6a..aca57ef 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,7 +25,7 @@ I swear I heard Joe mutter this while taking a nap at the office. One rule per issue. -When discussed and approved, it will be moved to either the *Conventions* or the *Great Ideas* list. If rejected, it will be moved to the *Rejected* list. +When discussed and approved, it will be moved to either the *Conventions* or the *Great Ideas* list. If rejected, it will be moved to the [*Rejected*](REJECTED.md) list. ### Acceptance criteria diff --git a/REJECTED.md b/REJECTED.md new file mode 100644 index 0000000..cdf5833 --- /dev/null +++ b/REJECTED.md @@ -0,0 +1,25 @@ +## Rejected rules and suggestions + +*** + +##### rule +> Use tail-recursive functions instead of foldl + +##### rejected because + We love high-order functions! + +*** + +##### rule +> Using ``'andalso'``, ``'orelse'``, and the like, might save a 'case' or two + +##### rejected because + They're not intended to be used that way and the resulting code messes up with dialyzer + +*** + +##### rule +> Replace ``lists:map`` with either ``lists:foreach`` or list comprehensions + +##### rejected because + There is not true that LCs are better than ``list:map`` in all scenarios.