Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make jquery-ui optional, and check if datepicker is present #136

Open
flocsy opened this issue Apr 11, 2013 · 1 comment
Open

make jquery-ui optional, and check if datepicker is present #136

flocsy opened this issue Apr 11, 2013 · 1 comment
Labels

Comments

@flocsy
Copy link

flocsy commented Apr 11, 2013

The description states "Load jQuery UI for datepicker support", this suggests that if I don't use datepicker, then I don't need jquery-ui. Unfortunatelly this is not the case, as in init it uses e.datepicker, but it only checks if jQuery.ui exists:

jQuery.ui && (e.datepicker._checkOffset

We have an optimized (not full) version of the datepicker for autocomplete, that doesn't include datepicker, so the code fails. An easy fix for this in that particular place is:

jQuery.ui && e.datepicker && (e.datepicker._checkOffset

but I can imagine that the same problem can appear in another places. As many people now download only the modules they really use in jquery-ui I would consider this to be a bug.

@elclanrs
Copy link
Owner

elclanrs commented May 2, 2013

Will look into this...Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants