Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink --pre-auto-entitlements (merge entitlement entries from provisioning profile) #191

Open
sethlu opened this issue Apr 28, 2019 · 2 comments
Assignees

Comments

@sethlu
Copy link
Contributor

sethlu commented Apr 28, 2019

Here's what electron-osx-sign does a little differently: Since Electron supports macOS features like Handoff, when app sandbox is enabled, electron-osx-sign (default with --pre-auto-entitlements) will automatically inject com.apple.developer.team-identifier into the entitlements to enable these features... and this entry must be whitelisted by a provisioning profile.

Therefore, electron-osx-sign requires provisioning profiles whenever app sandbox is enabled (applicable to MAS development and distribution). They will be picked up automatically if placed in the current working directory.

🤔 I think the this entitlements automation behavior will likely change in a next major release of electron-osx-sign so the presence of provisioning profile should be what adds in the whitelisted entitlement entries, instead of when app sandbox is enabled.

Originally posted by @sethlu in electron-userland/electron-builder#897 (comment)

@sethlu sethlu self-assigned this Apr 28, 2019
@jabetong1
Copy link

I get the same issue. Is there any enhancement in the entitlements automation?

@sethlu
Copy link
Contributor Author

sethlu commented May 8, 2019

@jabetong1 I'm not sure which issue you're encountering, but a solution is discussed in the original comment electron-userland/electron-builder#897 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants