Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC doesn't disambiguate displaynames. #2746

Open
ara4n opened this issue Nov 9, 2024 · 1 comment
Open

EC doesn't disambiguate displaynames. #2746

ara4n opened this issue Nov 9, 2024 · 1 comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Nov 9, 2024

Steps to reproduce

  1. Start an EC video call in a room with two different people called Matthew
  2. They both join
  3. There's no way to see which video comes from which user.

Outcome

What did you expect?

Like EW and EX (and all other Matrix clients should), users with the same-looking name should have their mxid appended after it in order to differentiate them from each other.

matrix-js-sdk should give us this almost for free via unhomoglyph - we just need to hook it up in the UX.

What happened instead?

Ambiguity and risk of impersonation.

Operating system

No response

Browser information

No response

URL for webapp

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 9, 2024
@hughns
Copy link
Member

hughns commented Nov 12, 2024

It would be trivial to wire up the RoomMember.name property which disambiguates between all Matrix room members. However, I think in EC we would only want to disambiguate between current MatrixRTC call members. This is significantly more complicated to do as the view models need refactoring to get the right context in the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants