Invisible Crypto: User Identity notices are displayed in unencrypted rooms

[BillCarsonFr]

Follow-up on #2491

Currently the TOFU identity change notice is displayed if you are in a non encrypted room

=> We might want to only show that in e2ee rooms.

(Definitly should not do it in clear room for verified identity changes)

Tasks

Preview Give feedback

1. Done on Android: Do not render pin violation in clear rooms. element-x-android#3630
2. Web will be done as part of: Invisible Crypto: Web: display a warning when an *unverified* user changes identity #2513
3. [Task] Invisible Crypto: User Identity notice are displayed in clear room element-x-ios#3409
   T-Task +1
   

[andybalaam]

Android: element-hq/element-x-android#3630

Web: we will do this as part of #2513

iOS: @mxandreas will make a ticket

[mxandreas]

Created a ticket for iOS, cc @manuroe .

[pixlwave]

How come this is a client-side issue and not an SDK issue? I would expect this callback to never be used when the room is unencrypted.

[andybalaam]

How come this is a client-side issue and not an SDK issue? I would expect this callback to never be used when the room is unencrypted.

So would you expect calling subscribe_to_identity_status_changes to do nothing in an unencrypted room? That would seem quite surprising to me...

I would have thought it would be more sensible not to call it in an unencrypted room?

[pixlwave]

Ah I see what you mean. We don't have any logic around what we do/don't subscribe to, my understanding of it being a client issue was to still subscribe to it and filter out any updates based upon the encryption state of the room. Doing what you suggested makes wayyy more sense to me though!

(It wouldn't handle the possibility of encryption being enabled by someone after opening the room, but I'm happy to ignore that if you aren't bothered about this edge case?).

[pixlwave]

PR here: element-hq/element-x-ios#3414

[andybalaam]

(It wouldn't handle the possibility of encryption being enabled by someone after opening the room, but I'm happy to ignore that if you aren't bothered about this edge case?).

Will it self-heal if you switch away to a different room and back? If so it seems pretty minor, but we should log it as a known issue.

[pixlwave]

Exactly, yes. We create one of the RoomProxy objects each time you open a room and dispose of it when you pop back out of that room flow.

we should log it as a known issue.

In an issue on EXI, or do you have a better place to track this on the crypto side?

[andybalaam]

In an issue on EXI, or do you have a better place to track this on the crypto side?

I would think EXI, and EXA if a similar problem exists there. cc @bmarty

[pixlwave]

Done here: element-hq/element-x-ios#3417

[andybalaam]

Awesome, thank you!

[manuroe]

thanks @pixlwave! I removed you as assignee to make clear that we do not work anymore on this item.