From 59cc9c27ecdaefa80a9abfb4986e35286243cae0 Mon Sep 17 00:00:00 2001 From: Stefan Ceriu Date: Wed, 29 Jan 2025 17:23:47 +0200 Subject: [PATCH] Attempt to fix the every flakey app lock setup test We noticed that confirming the PIN will automatically hide the keyboard which makes the whole screen shift down while attempting to press the allow button. We also see an `App animations complete notification not received, will attempt to continue.` warning which seems to point to the same issue. --- UITests/Sources/AppLockSetupUITests.swift | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/UITests/Sources/AppLockSetupUITests.swift b/UITests/Sources/AppLockSetupUITests.swift index bcd212322a..f17cf411a9 100644 --- a/UITests/Sources/AppLockSetupUITests.swift +++ b/UITests/Sources/AppLockSetupUITests.swift @@ -44,10 +44,17 @@ class AppLockSetupUITests: XCTestCase { enterPIN() + // This test has been especially flakey. We noticed that confirming the PIN will + // automatically hide the keyboard which makes the whole screen shift down while + // attempting to press the allow button. We also see an `App animations complete + // notification not received, will attempt to continue.` warning which seems to + // point to the same issue. + try await Task.sleep(for: .seconds(1.0)) + // Setup biometrics screen. try await app.assertScreenshot(.appLockSetupFlow, step: Step.setupBiometrics) - app.buttons[A11yIdentifiers.appLockSetupBiometricsScreen.allow].tap() + app.buttons[A11yIdentifiers.appLockSetupBiometricsScreen.allow].tapCenter() // Settings screen. try await app.assertScreenshot(.appLockSetupFlow, step: Step.settings)