Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show editing options for pictures in detail view. #2192

Closed
VolkerJunginger opened this issue Dec 1, 2023 · 3 comments
Closed

Don't show editing options for pictures in detail view. #2192

VolkerJunginger opened this issue Dec 1, 2023 · 3 comments
Labels
A-Media O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@VolkerJunginger
Copy link

Steps to reproduce

Send or receive a picture.

In the timeline tap on the picture.

The user has the option to edit the picture.

Remove the option to edit the picture.

Outcome

What did you expect?

What happened instead?

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@pixlwave
Copy link
Member

pixlwave commented Dec 5, 2023

Summarising a discussion with @VolkerJunginger about this as there is one useful flow here that we would lose:

Markup.mp4

With editing disabled, this flow becomes

  • Save the file to your device
  • Open the Files app
  • Navigate to the directory you saved the file to and open it
  • Edit the file
  • Come back to Element
  • Select the file and send it.

However from a product perspective the flow in the video recording isn't ideal as you have to copy and paste your edited file. When you compare this to using Markup in Mail, they are able to add extra items to the Done menu:

RPReplay_Final1701778723.mov

From what I can tell there isn't a public API that allows us to do this. @amshakal Any thoughts on this?

@pixlwave pixlwave added A-Media S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Dec 13, 2023
@amshakal
Copy link

amshakal commented Jan 4, 2024

@pixlwave I am unable to see the videos :/

@VolkerJunginger
Copy link
Author

Its ok. We decided not to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Media O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants