Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event IDs are not logged for sent events #2216

Closed
richvdh opened this issue Dec 8, 2023 · 5 comments · Fixed by matrix-org/matrix-rust-sdk#3163
Closed

Event IDs are not logged for sent events #2216

richvdh opened this issue Dec 8, 2023 · 5 comments · Fixed by matrix-org/matrix-rust-sdk#3163
Assignees
Labels
A-DevX Anything that can improve the DevX T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@richvdh
Copy link
Member

richvdh commented Dec 8, 2023

I believe that https://github.com/vector-im/element-x-ios-rageshakes/issues/1179 contains the transmission of Event ID $j1b1BiZ9mzTB7Mi15pgDVHC0l6Np6k4Vy6mEjfEHqNU, but I can't find it because it appears we don't log the ID of events we send.

@richvdh
Copy link
Member Author

richvdh commented Dec 8, 2023

obviously, this makes it hard to debug UISIs from EX senders.

@pixlwave
Copy link
Member

pixlwave commented Dec 8, 2023

@richvdh: This is probably a todo for SDK as the app sends items off to be queued in the SDK and then they basically get mixed into the timeline diffs like every other timeline item meaning the app never directly sees the response with the event ID.

@richvdh
Copy link
Member Author

richvdh commented Dec 8, 2023

Yes indeed! Filing the issue here wasn't meant to indicate any particular prejudice about the best way to solve the problem - just that the net result is that Element X iOS doesn't log the event ID.

@pixlwave pixlwave added A-DevX Anything that can improve the DevX X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Dec 11, 2023
@BillCarsonFr BillCarsonFr self-assigned this Feb 23, 2024
@richvdh
Copy link
Member Author

richvdh commented Feb 26, 2024

Thanks for the fix @BillCarsonFr!

Does this need an update to the Element X to use the new rust-sdk version, or will it get picked up automatically?

@poljar
Copy link
Contributor

poljar commented Feb 26, 2024

As mentioned in a call, this will be eventually picked up by EX as it requires other new features from the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-DevX Anything that can improve the DevX T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
4 participants