Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Confirm your recovery key” is strange lanuage given you haven’t already entered your key #2221

Closed
ara4n opened this issue Dec 10, 2023 · 4 comments
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@ara4n
Copy link
Member

ara4n commented Dec 10, 2023

Steps to reproduce

  1. At various points the app asks you to “confirm your recovery key”.
  2. What it’s actually asking you to do is “enter your recovery key”
  3. You’re not confirming it, as that would imply you have already entered it at some point already, and this is a confirmation prompt, rather than asking you to enter it for the first time.

Outcome

What did you expect?

prompt should be “enter your recovery key” or “provide your recovery key”

What happened instead?

a strange misuse of the word “confirm”, which is normally used in UI to mean a confirmational check of a user’s actions, rather than prompting for an action in the first place.

Your phone model

No response

Operating system version

No response

Application version

457

Homeserver

No response

Will you send logs?

No

@ara4n
Copy link
Member Author

ara4n commented Dec 10, 2023

see also #2217

@pixlwave pixlwave added T-Defect A-E2EE Encryption S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely X-Needs-Design labels Dec 12, 2023
@ara4n
Copy link
Member Author

ara4n commented Dec 13, 2023

see also #2243

@ara4n
Copy link
Member Author

ara4n commented Dec 23, 2023

it should also have coherent text for users who didn't have backup set up in the first place

@pmaier1
Copy link

pmaier1 commented Feb 19, 2024

There are at least two user flows where you need to enter your recovery key to fix things

  1. Your device is unverified and you don't have another device to verify it
  2. Your key backup is borked (your device doesn't have all the secrets it needs to operate the backup)

For 1, I suggest we offer the options
a) Use another device
b) Use recovery key

For 2, I suggest we change the copy to "Enter recovery key", keeping the subtext "Your chat backup is currently out of sync"

cc @americanrefugee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

3 participants