Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sill stuck on "Confirm your Identity" after doing Can't Confirm and reset identity #3718

Closed
BillCarsonFr opened this issue Jan 30, 2025 · 5 comments
Assignees
Labels
A-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Regression

Comments

@BillCarsonFr
Copy link
Member

Image

@BillCarsonFr
Copy link
Member Author

Probably related to #3717

@BillCarsonFr
Copy link
Member Author

The issue was 100% reproducable on matrix org but is not anymore..
As per the logs, we can see the 2 uploads for the reset, the new cross signing key then the new signature. But after that there is no keys/query request made.. So the sdk is not updated with the new verification status

2025-01-30T15:07:35.835036Z DEBUG matrix_sdk::http_client: Got response | crates/matrix-sdk/src/http_client/mod.rs:221 | spans: root > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s, retry_limit: 0 } request_id="REQ-37" method=POST uri="https://matrix-client.matrix.org/_matrix/client/v3/keys/device_signing/upload" request_size="1.4 kiB" status=200 response_size="2 B"}
2025-01-3015:07:39.721678Z DEBUG matrix_sdk::http_client: Got response | crates/matrix-sdk/src/http_client/mod.rs:221 | spans: root > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s, retry_limit: 0 } request_id="REQ-38" method=POST uri="https://matrix-client.matrix.org/_matrix/client/v3/keys/signatures/upload" request_size="518 B" status=200 response_size="15 B"}

There is a key query but just before:

2025-01-30T15:07:15.085939Z DEBUG matrix_sdk_crypto::identities::manager: Finished handling of the `/keys/query` 

https://rageshakes.element.io/api/listing/2025-01-30/155047-KT74TNC7/console.2025-01-30-15.log.gz

At this point it is unclear if:

  • It is a race problem on the SDK that wrongly marks the own user as up-to-date instead of dirty
  • Or it's on synapse side that returns slightly outdated DeviceKeys payload that the sdk will then use to mark the user as up-to-date.

Looks similar to this issue, were a keys/query is not done: element-hq/element-meta#2594

@BillCarsonFr BillCarsonFr self-assigned this Jan 31, 2025
@andybalaam
Copy link
Member

@poljar says this is similar to something @stefanceriu has seen when doing user verification work.

@andybalaam
Copy link
Member

@BillCarsonFr has a PR to add logging to sdk to help diagnose.

@Velin92 Velin92 added T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue S-Critical Prevents work, causes data loss and/or has no workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Backup labels Feb 3, 2025
@stefanceriu
Copy link
Member

I'm not able to reproduce problems anymore on neither reset nor user verification (matrix.org). I tried multiple times on each with different SDK versions but I always reliably get device_list changes and the clients update accordingly.

I'll keep an eye out for issue as I still have quite a bit of work left to do on user verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Backup O-Occasional Affects or can be seen by some users regularly or most users rarely S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue X-Regression
Projects
None yet
Development

No branches or pull requests

4 participants