Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back to UIKit for the presentation of the timeline media preview. #3719

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Revert back to UIKit for the presentation of the timeline media preview. #3719

merged 7 commits into from
Jan 31, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 30, 2025 •
edited
Loading

This PR essentially undoes #3619 as embedding the QLPreviewController wasn't going so well:

  • Interactive dismiss broke in iOS 18.2 (it triggered immediately instead of letting you slowly drag down).
  • Attempting to add any interactivity on top of the preview controller made the preview completely un-interactive.
  • The audio player didn't show the progress waveform as it attempted to attach it to it's own bottom bar which it was unable to present.
  • Sometimes a preview would present without a navigation bar as the preview controller really wants to mess with it in all kinds of ways.

This means we lose some control and have to accept the iOS defaults, but it works much better and that's important seeing as we'll be replacing the timeline previews too to enable swiping. The last commit is a bit of a workaround but it seems good enough for now.

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-30.at.16.37.53.mp4

@pixlwave pixlwave requested a review from a team as a code owner January 30, 2025 16:38
@pixlwave pixlwave requested review from stefanceriu and removed request for a team January 30, 2025 16:38
@pixlwave pixlwave added the pr-change for updates to an existing feature label Jan 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.23647% with 408 lines in your changes missing coverage. Please review.

Project coverage is 78.37%. Comparing base (ef340fb) to head (d277c1e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ewScreen/View/TimelineMediaPreviewController.swift 0.00% 266 Missing ⚠️
...lePreviewScreen/TimelineMediaPreviewModifier.swift 10.16% 106 Missing ⚠️
...ineScreen/MediaEventsTimelineScreenViewModel.swift 16.66% 20 Missing ⚠️
...PreviewScreen/TimelineMediaPreviewDataSource.swift 20.00% 4 Missing ⚠️
...eScreen/MediaEventsTimelineScreenCoordinator.swift 0.00% 4 Missing ⚠️
...rdinators/MediaEventsTimelineFlowCoordinator.swift 0.00% 3 Missing ⚠️
...s/Sources/TimelineMediaPreviewViewModelTests.swift 88.88% 3 Missing ⚠️
...FilePreviewScreen/TimelineMediaPreviewModels.swift 96.00% 1 Missing ⚠️
...imelineScreen/View/MediaEventsTimelineScreen.swift 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3719      +/-   ##
===========================================
- Coverage    78.73%   78.37%   -0.36%     
===========================================
  Files          792      794       +2     
  Lines        68216    68594     +378     
===========================================
+ Hits         53709    53762      +53     
- Misses       14507    14832     +325
Flag Coverage Δ
unittests 70.39% <18.23%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefanceriu
stefanceriu approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly skimmed it because a lot of the code moved around but it lgtm, nothing jumped out 👍

ElementX/Sources/Screens/FilePreviewScreen/TimelineMediaPreviewModifier.swift Show resolved Hide resolved
@pixlwave pixlwave force-pushed the doug/media-timeline-ends branch from d70e295 to af17379 Compare January 31, 2025 15:48
@pixlwave pixlwave force-pushed the doug/media-timeline-ends branch from c96086c to d277c1e Compare January 31, 2025 17:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pixlwave pixlwave merged commit 6cd583d into develop Jan 31, 2025
13 checks passed
@pixlwave pixlwave deleted the doug/media-timeline-ends branch January 31, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-change for updates to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixlwave @stefanceriu