The CI will publish artifacts on a new release, instead of using the draft one

[sandhose]

This has not been fixed by #17970

[anoadragon453]

Hopefully now fixed by #17995. Will test during the 1.121.0rc1 release.

[anoadragon453]

The CI still created a new release. Perhaps this is a change on GitHub's side? How are other projects getting around this? Are we using a different config?

[anoadragon453]

It also creates it as a published, full release, instead of a pre-release 🤦

[anoadragon453]

And causes the release script to break, as the release is already published. Meaning the release admin needs to resort to running the following steps manually:

Click to view release script traceback

*** publish ***
Publish release v1.121.0rc1 on GitHub? [Y/n]: 
Traceback (most recent call last):
  File "/home/work/code/synapse/./scripts-dev/release.py", line 974, in <module>
    cli()
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/./scripts-dev/release.py", line 756, in full
    _publish(gh_token)
  File "/home/work/code/synapse/./scripts-dev/release.py", line 452, in _publish
    release = release.update_release(
              ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/github/GitRelease.py", line 229, in update_release
    headers, data = self._requester.requestJsonAndCheck("PATCH", self.url, input=post_parameters)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/github/Requester.py", line 586, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, self.__customConnection(url)))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/work/code/synapse/.venv/lib/python3.12/site-packages/github/Requester.py", line 744, in __check
    raise self.createException(status, responseHeaders, data)
github.GithubException.GithubException: 422 {"message": "Validation Failed", "errors": [{"resource": "Release", "code": "already_exists", "field": "tag_name"}], "documentation_url": "https://docs.github.com/rest/releases/releases#update-a-release", "status": "422"}