Merge pull request #1875 from pragdave/iex-c-error

Catch attempts to compile missing files in iex and give slightly tidier error messages

Author: José Valim

lib/iex/lib/iex/helpers.ex

@@ -69,7 +69,16 @@ defmodule IEx.Helpers do
       raise ArgumentError, message: "expected a binary or a list of binaries as argument"
     end
 
-    { erls, exs } = Enum.partition(files, &String.ends_with?(&1, ".erl"))
+    { found, not_found } = Enum.map(files, &Path.join(path, &1)) |> Enum.partition(&File.exists?/1)
+
+    unless Enum.empty?(not_found) do
+      IO.puts IEx.color(:eval_error, %s[Cannot find #{Enum.join(not_found, ", ")}])
+      unless Enum.empty?(found) do
+        IO.puts IEx.color(:eval_info, "(remaining file(s) will be compiled)")
+      end
+    end
+
+    { erls, exs } = Enum.partition(found, &String.ends_with?(&1, ".erl"))
 
     modules = Enum.map(erls, fn(source) ->
       { module, binary } = compile_erlang(source)

lib/iex/test/iex/helpers_test.exs

@@ -251,6 +251,23 @@ defmodule IEx.HelpersTest do
     cleanup_modules([:sample])
   end
 
+
+  test "c helper skips unknown files" do
+    assert_raise UndefinedFunctionError, "undefined function: :sample.hello/0", fn ->
+      :sample.hello
+    end
+
+   filenames = ["sample.erl", "not_found.ex", "sample2.ex"]
+   with_file filenames, [erlang_module_code, "", another_test_module], fn ->
+      assert c(filenames) |> Enum.sort == [Sample2, :sample]
+      assert :sample.hello == :world
+      assert Sample2.hello == :world
+    end
+  after
+    cleanup_modules([:sample, Sample2])
+  end
+
+
   test "l helper" do
     assert_raise UndefinedFunctionError, "undefined function: Sample.run/0", fn ->
       Sample.run