Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should use xlink:href and not href? #53

Open
rupertlssmith opened this issue Dec 5, 2022 · 0 comments
Open

Should use xlink:href and not href? #53

rupertlssmith opened this issue Dec 5, 2022 · 0 comments

Comments

@rupertlssmith
Copy link
Contributor

https://github.com/elm-community/typed-svg/blob/master/src/TypedSvg/Attributes.elm#L1144

The comment says:

"The xlinkHref attribute is used before SVG 2 but is now rendered obsolete by href."

But this seems bad advice since SVG 2 is never really completed? The standard is still SVG 1.1 if you want compatibility, so should use "xlink:href"?

Solution: Just change the comment to suggest using xlink:href, if the above is correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rupertlssmith