Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp-ltex-active-modes has no effect #45

Open
real-or-random opened this issue Jul 9, 2024 · 3 comments
Open

lsp-ltex-active-modes has no effect #45

real-or-random opened this issue Jul 9, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@real-or-random
Copy link
Contributor

When I set lsp-ltex-active-modes after the package is loaded, it'll be too late.
It needs to be set before loading the package, but that's a bit inconvenient and not documented.

Ideally, the init code of the package should not run when loading the package, but it should be in wrapped in a function that can be called instead of (require 'lsp-ltex).

(That has also been reported as a side note in #42.)

@jcs090218
Copy link
Member

Confirmed, you are correct. 🤔 Everything has to be configured before it's loaded.

@jcs090218 jcs090218 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 30, 2024
@real-or-random
Copy link
Contributor Author

Thanks for acknowledging. I saw that you've added the "documentation" label. Fixing the docs will certainly be an improvement. Let me say though that I think the best fix is what I described above:

Ideally, the init code of the package should not run when loading the package, but it should be in wrapped in a function that can be called instead of (require 'lsp-ltex).

@jcs090218
Copy link
Member

Sorry, I'm a bit busy these days. Anyway, feel free to open PRs for this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants