Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade needed linum to new line number mode #30

Open
Aneeqasif opened this issue Nov 25, 2023 · 6 comments
Open

upgrade needed linum to new line number mode #30

Aneeqasif opened this issue Nov 25, 2023 · 6 comments
Labels
question Further information is requested

Comments

@Aneeqasif
Copy link

image

i am not a emacs expert but it seems like linum mode is obsolete which this package is making use of and enabling this cause unwanted double line in emacs if only way to use this package with default doom emacs is by using indicators which donot loook as visually good as the linum option provide. i hope u get my point. please adress this issue thanks :)

@jcs090218
Copy link
Member

The current recommendation is to use display-line-numbers-mode (the newer line number mode) plus the indicators option. Unfortunately, display-line-numbers-mode doesn't allow you to customize the format like linum-mode does. 😓

@jcs090218 jcs090218 added the question Further information is requested label Nov 26, 2023
@Aneeqasif
Copy link
Author

yeah i can understand it is not a big deal though i just wanted the indicator bitmaps to look visually more like they are a one single hunk instead of sperated lines for each line but ig its not possible with indicators so i am happy that i get to use this package thats enough for me .

@Aneeqasif
Copy link
Author

do u know of any alternatives for this package ?

@jcs090218
Copy link
Member

I just wanted the indicator bitmaps to look visually more like they are a one single hunk instead of sperated lines for each line but ig its not possible with indicators so i am happy that i get to use this package thats enough for me .

I'm not quite sure if I understand this. You can design bitmap in any way you want! 😀

do u know of any alternatives for this package ?

The closest I could think of is git-gutter or diff-hl.

@Aneeqasif
Copy link
Author

i mean with default settings mine look like this

image

(add-hook 'prog-mode-hook  'line-reminder-mode)
(add-hook 'org-mode-hook 'line-reminder-mode)
(setq line-reminder-bitmap 'line-reminder--default-bitmap)
(setq line-reminder-thumbnail t)
(setq line-reminder-show-option 'indicators)

while yours look like this

image

how can i make the bitmaps to look like its a part of same line as you have shown in screen shot i have tried it with jetbrainsmono and iosevka fonts any clue?

@jcs090218
Copy link
Member

Try

(fringe-helper-define 'my-bitmap nil
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.." "..xxx.."
  "..xxx.." "..xxx..")

(setq line-reminder-bitmap 'my-bitmap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants