Skip to content

Commit 7b6fa2a

Browse files
authored
Merge pull request #5 from emartech/axios
feat(logger): handle non-existing response object
2 parents 7914f02 + 792ed08 commit 7b6fa2a

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

src/logger/logger.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,26 @@ class Logger {
6666
}
6767

6868
_getErrorDetails(error) {
69-
const details = {
69+
const baseDetails = {
7070
error_name: error.name,
7171
error_stack: this._shortenStackTrace(error.stack),
7272
error_message: error.message,
7373
error_data: this._shortenData(error.data)
7474
};
7575

76-
if (error.isAxiosError) {
77-
details.request_method = error.config.method;
78-
details.request_url = error.config.url;
79-
details.response_status = error.response.status;
80-
details.response_status_text = error.response.statusText;
81-
details.response_data = this._shortenData(error.response.data);
82-
}
76+
return Object.assign(baseDetails, this._getAxiosErrorDetails(error));
77+
}
8378

84-
return details;
79+
_getAxiosErrorDetails(error) {
80+
if (!error.isAxiosError) return {};
81+
82+
return {
83+
request_method: error.config.method,
84+
request_url: error.config.url,
85+
response_status: error.response ? error.response.status : undefined,
86+
response_status_text: error.response ? error.response.statusText : undefined,
87+
response_data: error.response ? this._shortenData(error.response.data) : undefined
88+
};
8589
}
8690
}
8791

0 commit comments

Comments
 (0)