setupPodConfig doesn't work in newer ember-cli versions

[Windvis]

I bumped ember-cli to v5+ in ember-source and the pod related tests no longer work as expected.

The setupPodConfig util no longer works since the disableAnalytics key has been removed from the .ember-cli config file.

ember-cli-blueprint-test-helpers/lib/setup-pod-config.js

Line 18 in c6cd81d

replaceFile('.ember-cli', '"disableAnalytics": false', '"disableAnalytics": false,\n"usePods" : true\n');

We should update that so it doesn't depend on the contents of the .ember-cli file

[mansona]

so... we really shouldn't be doing anything with pods any more. They were never an officially supported feature and we can't keep maintaining it forever. If our testing infrastructure supports anything around pods that should be removed 👍

[Windvis]

@mansona While I agree about pods personally, I don't think we can simply drop them without a deprecation, even if it was never officially supported. The related RFC issue made it clear that a lot of teams are still using pods.

While simply removing the tests doesn't remove pods support itself, it does increase the chance of accidentally breaking it in the future.

Fixing this issue shouldn't be too hard, so that seems the best way to unblock the ember-source issue?

[mansona]

you only need an RFC to remove a feature that is officially supported, Pods never had a RFC and never got officially supported.

And while you're probably right that it shouldn't be too hard to fix, that's not the reason that I'm bringing this up. We shouldn't be making our CI any more complicated to support an unsupported feature. I'll add this question to the next tooling meeting agenda to see if there is a way forward here

[ef4]

The spec meeting discussed this and decided it's worth the effort to write down a "deprecate pods" RFC, because clarify of communication is needed.

That said, if somebody is motivated to fix this bug that's also fine. It's still helpful to remove blockers for people who are updating things.